feat: store sent notifications to DB by busehalis-sap · Pull Request #52 · cap-java/cds-feature-notifications

busehalis-sap · 2026-07-27T13:07:19Z

Summary

Some applications need the notifications stored to DB to do further processing with them. This PR adds optional DB storage for sent notifications in both production and local mode.

When cds.notifications.storeNotifications: true is set, each notification is stored to the database after being sent. In production mode, the ANS-assigned notification ID is used directly. In local mode, a UUID is generated locally. Since a single notification can be sent to multiple recipients, one row per recipient is created.

Changes

NotificationStorage.cds: CDS model with @PersonalData annotations for Notifications, NotificationProperties and NotificationTargetParameters entities
StoreNotificationsHandler: @After handler on NotificationProviderService that stores notifications to DB after ANS delivery in production mode
StoreNotificationsLocalHandler: @After handler on ApplicationService that stores notifications to DB in local mode
NotificationStorageHelper: shared helper class containing the DB persistence logic used by both handlers
LocalHandler: sets the sent notifications on the event context so StoreNotificationsLocalHandler can access them
NotificationServiceConfiguration: reads storeNotifications flag and conditionally registers the appropriate handler based on the current mode
Integration tests: 4 new tests covering DB storage, properties, target parameters and multiple recipients, and 1 test for local mode
Sample app: demonstrates the feature with StoredNotifications projection and key bookId field

…ample app

…GELOG

…oreNotificationsIntegrationTest

…ng fully qualified name

lisajulia

Some small changes, otherwise this is fine :)
Thanks!

lisajulia · 2026-07-29T06:10:54Z

+
+    Instant sentAt = Instant.now();
+
+    for (int i = 0; i < results.size(); i++) {


Possibly add a check here that results and entries have the same size.

Good catch on the size check suggestion! Looking at this more carefully, I realized the loop itself is unnecessary.

In ProductionHandler, each notification is inserted individually in a loop:

for (int i = 0; i < results.size(); i++) { notificationProviderService.run(Insert.into(Notifications_.CDS_NAME).entry(notification)); }

Each run(Insert...) call is a separate OData POST request. Since StoreNotificationsHandler is an @after(EVENT_CREATE) handler on NotificationProviderService, it is triggered after each individual run() call, not once for the entire batch.

I simplified the handler to use results.get(0) and entries.get(0) directly, and removed the loop. The size check is also not needed for the same reason. results.size() will always equal entries.size() (both always 1), since this handler fires per individual insert, not per batch.

lisajulia · 2026-07-29T06:13:40Z

+    this.storageService = storageService;
+  }
+
+  @After(event = "*")


This will be after every event, right? Is it possible to narrow that down?

Narrowing it down would require more complex architectural changes. The filtering already happens at the top of the method with a simple map lookup, which is very cheap. EntityNotificationHandler uses the same pattern.

Also, it affects local only therefore not that relevant anyway. Tested it out and it worked :)

lisajulia · 2026-07-29T06:14:57Z

+  priority                    : String(20);
+  navigationTargetObject      : String(500);
+  navigationTargetAction      : String(500);
+  sentAt                      : Timestamp;


Mention in the readme that this is UTC time.

Schmarvinius

just minor stuff

Schmarvinius · 2026-07-28T14:47:20Z

+  @After(event = CqnService.EVENT_CREATE, entity = Notifications_.CDS_NAME)
+  public void storeNotifications(CdsCreateEventContext context) {


can be simplified

Suggested change

@After(event = CqnService.EVENT_CREATE, entity = Notifications_.CDS_NAME)

public void storeNotifications(CdsCreateEventContext context) {

@After

public void storeNotifications(CdsCreateEventContext context, List<CdsData> data) {

Schmarvinius · 2026-07-28T15:05:37Z

+        configurer
+            .getCdsRuntime()
+            .getEnvironment()
+            .getProperty("cds.requires.notifications.storeNotifications", Boolean.class, false);


cds.requires is the namespace for require service confiugration -> feature toggles are in cds.

Suggested change

.getProperty("cds.requires.notifications.storeNotifications", Boolean.class, false);

.getProperty("cds.notifications.storeNotifications", Boolean.class, false);

Schmarvinius · 2026-07-28T15:12:05Z

+import org.slf4j.LoggerFactory;
+
+/** Shared service for persisting notifications to the database. */
+public class NotificationStorageService {


This class isn't a service (in cap terms) it is a normal pojo

…ture

… instead of cds.requires

…ld is stored in UTC

…dler is triggered per insert

Schmarvinius

think its fine but please await lisas review as well

busehalis-sap added 4 commits July 27, 2026 14:57

feat: store sent notifications to DB when storeNotifications is enabled

e49220d

test: add integration tests for storing notifications to DB

385cfcb

chore: demonstrate storeNotifications and TargetParameters usage in s…

3197265

…ample app

docs: document Storing Notifications to DB feature in README and CHAN…

4e22234

…GELOG

busehalis-sap requested a review from Schmarvinius July 27, 2026 13:07

test: await DB write instead of mock handler notification count in St…

74e8aa7

…oreNotificationsIntegrationTest

busehalis-sap requested a review from lisajulia July 27, 2026 13:27

busehalis-sap added 3 commits July 27, 2026 15:57

fix: import Service class in StoreNotificationsHandler instead of usi…

a406f99

…ng fully qualified name

feat: support storing notifications to DB in local mode

24cef81

test: add integration test for storing notifications to DB in local mode

2060d53

lisajulia requested changes Jul 29, 2026

View reviewed changes

Schmarvinius requested changes Jul 29, 2026

View reviewed changes

busehalis-sap added 5 commits July 29, 2026 13:43

refactor: simplify StoreNotificationsHandler using typed method signa…

a8eb6f6

…ture

refactor: use cds.notifications namespace for storeNotifications flag…

3cb1745

… instead of cds.requires

refactor: rename NotificationStorageService to NotificationStorageHelper

dd4a586

docs: document stored fields for notifications and mention sentAt fie…

30fc3da

…ld is stored in UTC

refactor: remove unnecessary loop in StoreNotificationsHandler as han…

ce9aedc

…dler is triggered per insert

busehalis-sap requested review from Schmarvinius and lisajulia July 29, 2026 12:51

Schmarvinius approved these changes Jul 29, 2026

View reviewed changes


		Instant sentAt = Instant.now();

		for (int i = 0; i < results.size(); i++) {

		@After(event = CqnService.EVENT_CREATE, entity = Notifications_.CDS_NAME)
		public void storeNotifications(CdsCreateEventContext context) {

	.getProperty("cds.requires.notifications.storeNotifications", Boolean.class, false);
	.getProperty("cds.notifications.storeNotifications", Boolean.class, false);

Uh oh!

Conversation

busehalis-sap commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Uh oh!

lisajulia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Schmarvinius left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Schmarvinius Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Schmarvinius left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

busehalis-sap commented Jul 27, 2026 •

edited

Loading

Schmarvinius Jul 28, 2026 •

edited

Loading